Remove the text "Warning" from warning #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gov uk design system doesn't show the text "Warning" in the Warning text, just the warning text icon and the actual text. This change makes the text "Warning" hidden to make it consistent with govuk design system
|
Thanks for the pull request. The current version supports version 4.8.0 of the govuk design system. With the rapid updates to the 5.x versions since March 1st 2024 we'll need to think of how to track these changes better so it's easy to see which versions are compatible. Most likely the easiest path is simply to keep the same version numbers, so 5.3 of crispy-forms-gds is used with 5.3 of the govuk frontend. We'll merge in your pull request when we start that work (won't be long since we don't want to fall behind). |
StuartMacKay
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gov uk design system doesn't show the text "Warning" in the Warning text, just the warning text icon and the actual text. This change makes the text "Warning" hidden to make it consistent with govuk design system
Referemce: https://design-system.service.gov.uk/components/warning-text/